[vlc-devel] [PATCH] [RFC] input: set "input-current" early so control interfaces can control earlier

Steve Lhomme robux4 at gmail.com
Tue Oct 27 08:07:53 CET 2015


On Mon, Oct 26, 2015 at 4:43 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> On Monday 26 October 2015 08:59:29 Steve Lhomme wrote:
>> For Chromecast we want to be able to set a custom sout for the selected
>> input to play but the control interface get the event too late and the
>> input thread has already created its sout/vout.
>
> That callback is for interfaces to update their views and register callbacks
> with the input. Modifying the input there won´t work as you can (and typically
> do) have more than one interface running.

I assume none of them do that at the moment. So it shouldn't be an
issue if only one does. For the moment I only force the "sout" so that
it matches what we negotiated with the Chromecast. If it's done too
late in some case (race condition) I get a vout instead of the sout
needed by the Chromecast.

https://github.com/robUx4/vlc/blob/cc_wip/modules/control/chromecast/chromecast.cpp#L321

Also we don't want the user to have to figure out the sout to use for
each file VLC is going to play. Depending on the source we might
transcode or just transmux or even just serve the file as-is
(hopefully the pre-parser is versatile enough that we can make the
right decision at that stage).

I am fine with introducing a more "on hands" time of interface
controller if necessary.

> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list