[vlc-devel] [vlc-commits] subpicture: fix leak

[Rémi Denis-Courmont]

Le 2015-09-02 11:55, Thomas Guillem a écrit :
> On Sat, Aug 29, 2015, at 16:45, Rémi Denis-Courmont wrote:
>> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat 
>> Aug 29
>> 17:45:27 2015 +0300| [45e9b837dfadf004d5612f317826e92e3802fc0a] |
>> committer: Rémi Denis-Courmont
>>
>> subpicture: fix leak
>
> This causes a double free with .srt.
>
> The text segment is also freed from subpicture_Delete() via the
> p_subpic->updater.pf_destroy callback.

No, the segment is not freed without this patch, at least not in the 
common case. This is easily verified with either valgrind or asan.

-- 
Rémi Denis-Courmont
http://www.remlab.net/