[vlc-devel] [RFC PATCH 0/2] decoder: restart module if fmt_in changes

[Thomas Guillem]

On Mon, Sep 7, 2015, at 15:00, Rémi Denis-Courmont wrote:
> Le 2015-09-07 15:48, Thomas Guillem a écrit :
> > I have several comments:
> >
> >  - When we restart the decoder module, should we insure that we 
> > re-open the
> >    same module than before ? Currently it's not the case.
> 
> Definitely not: The format could change in such ways that the old 
> decoder can no longer decode (especially hardware accelerated ones).
> 
> >  - Nothing force the new decoder module to need a packetizer. In the
> > case where    it doesn't need one, I decided to unload the packetizer 
> > and
> > continue without it. Not sure it's the best thing to do.
> 
> I doubt that will work. Most (if not all) packetizers cache and delay 
> payloads internally, such that data will be lost if you ever unload the 
> packetizer.
> 
> If at all possible, I would phase out !b_need_packetizer. Most video 
> codecs need a packetizer, and the performance impact on non-packetized 
> audio and subtitle decoders should be negligible.

Then, should we add a b_packetized variable in decoder_t to inform the
decoder module if data will be packetized ? That way, some decoders will
able to fail at init if they are known to work only with packetized
data.

> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel