[vlc-devel] [RFC PATCH 0/2] decoder: restart module if fmt_in changes

[Thomas Guillem]

On Mon, Sep 7, 2015, at 16:07, Rémi Denis-Courmont wrote:
> Le 2015-09-07 16:49, Thomas Guillem a écrit :
> > On Mon, Sep 7, 2015, at 15:36, Rémi Denis-Courmont wrote:
> >> Le 2015-09-07 16:30, Thomas Guillem a écrit :
> >> > Then, should we add a b_packetized variable in decoder_t to inform
> >> > the
> >> > decoder module if data will be packetized ? That way, some 
> >> decoders
> >> > will
> >> > able to fail at init if they are known to work only with 
> >> packetized
> >> > data.
> >>
> >> How do you decide when to use a packetizer then though?
> >
> > If we decide to phase out b_need_packetizer, then we always try to
> > create a packetizer before the decoder. So, b_packetized will always 
> > be
> > true except for the case where no packetizer could be created (if a
> > module is missing for example).
> 
> For better or worse, the "copy" packetizer is always available (unless 
> the build is broken), though it does not actually perform packetization 
> (it only fixes the length field).

OK. Futhermore, there is already a b_packetized in fmt.

I found out that for mp3, fmt_in.b_packetized is already true, so the
DecoderThread doesn't need one. Indeed, the demux "es" is already
packeting the input (according to the module tree).

> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel