[vlc-devel] [PATCH 3/3] stream_demux: add stream_DemuxGetStatus

[Rémi Denis-Courmont]

Le 2015-09-14 16:55, Francois Cartegnie a écrit :
> Le 14/09/2015 15:46, Rémi Denis-Courmont a écrit :
>>> Owner passes data to stream_Demux, and its demux returns whenever,
>>> whatever it wants.
>>
>> So what?
>>
>> 1) The owner already knows when the stream reaches EOF, by 
>> definition.
>
> Owner's stream EOF does not mean stream_Demux demuxer EOF.
> Demux still have to drain stream_Demux fifo, and its own internal 
> buffers.
>
>> 2) The owner can not wait for the demux to finish, which may be an
>> issue. But the patch does not address it.
>
> It can't wait, but it can't also delete it before job is done.

Actually, it's supposed to do exactly that. stream_demux is for 
asynchronous demuxing afterall.
Waiting is not possible without introducing dead locks. Besides, if you 
want to wait, then you are better off with a synchronous child demux; 
stream_demux is counter-productive.

But that's besides the point: the patch does not solve that problem 
either way.

-- 
Rémi Denis-Courmont
http://www.remlab.net/