[vlc-devel] [PATCH 01/13] add field to subs_format_t, which decoder must recognize

[Rémi Denis-Courmont]

Le 2015-09-16 16:49, Aaron Wang a écrit :
> ---
>  include/vlc_es.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/vlc_es.h b/include/vlc_es.h
> index 97cdb78..5644b75 100644
> --- a/include/vlc_es.h
> +++ b/include/vlc_es.h
> @@ -363,6 +363,7 @@ struct subs_format_t
>      } teletext;
>
>      text_style_t *p_style; /* Default styles to use */
> +    int i_ord; /*if a 2nd 3rd .. subtitle*/

IMHO, this does not belong here. subs_format_t is part of es_format_t. 
That is meant for the demuxer or the packetizer to describe the ES.

Besides the way that you set i_ord in following es_out.c changes is not 
thread-safe and effectively undefined. You can't touch the decoder's 
formats after the decoder is thread has already started (in 
input_DecoderCreate).

>  };
>
>  /**

-- 
Rémi Denis-Courmont
http://www.remlab.net/