[vlc-devel] [PATCH 02/13] try to add a hotkey

[Rémi Denis-Courmont]

Le 2015-09-16 16:49, Aaron Wang a écrit :
> ---
>  src/config/keys.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/config/keys.c b/src/config/keys.c
> index 94e5cf5..b42fbe2 100644
> --- a/src/config/keys.c
> +++ b/src/config/keys.c
> @@ -264,7 +264,7 @@ found:
>  struct action
>  {
>      char name[MAXACTION];
> -    vlc_action_t value;
> +    vlc_action_t value;//an enum

Here and also in following patches, please avoid inserting comments in 
otherwise unmodified code chunks. It makes reviewing harder.

>  };
>
>  static const struct action actions[] =
> @@ -358,6 +358,8 @@ static const struct action actions[] =
>      { "subtitle-text-scale-up", ACTIONID_SUBTITLE_TEXT_SCALE_UP, },
>      { "subtitle-toggle", ACTIONID_SUBTITLE_TOGGLE, },
>      { "subtitle-track", ACTIONID_SUBTITLE_TRACK, },
> +    { "subtitle2-toggle", ACTIONID_SUBTITLE_TOGGLE2, },//2 is larger
> +    { "subtitle-track2", ACTIONID_SUBTITLE_TRACK2, },

Ordering is incorrect.

>      { "title-next", ACTIONID_TITLE_NEXT, },
>      { "title-prev", ACTIONID_TITLE_PREV, },
>      { "toggle-autoscale", ACTIONID_TOGGLE_AUTOSCALE, },

-- 
Rémi Denis-Courmont
http://www.remlab.net/