[vlc-devel] [PATCH] Remove simple Settings shortcut list click action

[David Fuhrmann]

> Am 22.09.2015 um 18:19 schrieb epirat07 at gmail.com:
> 
> From: Marvin Scholz <epirat07 at gmail.com>
> 
> This removes the simple settings shortcut list click action,
> as it causes the Change Shortcut dialog to open even when clicking
> on the list header. Additonally it feels weird to trigger this
> dialog with just a single click.
> ---
> .../package/macosx/Resources/English.lproj/SimplePreferences.xib   | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/extras/package/macosx/Resources/English.lproj/SimplePreferences.xib b/extras/package/macosx/Resources/English.lproj/SimplePreferences.xib
> index bb49ab0..8ce38d8 100644
> --- a/extras/package/macosx/Resources/English.lproj/SimplePreferences.xib
> +++ b/extras/package/macosx/Resources/English.lproj/SimplePreferences.xib
> @@ -1,9 +1,9 @@
> <?xml version="1.0" encoding="UTF-8" standalone="no"?>
> -<document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="8152.3" systemVersion="15A216g" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none">
> +<document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="8191" systemVersion="14F27" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none">
>     <dependencies>
>         <deployment version="1070" identifier="macosx"/>
>         <development version="5100" identifier="xcode"/>
> -        <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="8152.3"/>
> +        <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="8191"/>
>     </dependencies>
>     <objects>
>         <customObject id="-2" userLabel="File's Owner" customClass="VLCSimplePrefs">
> @@ -1774,7 +1774,7 @@ Gw
>                         <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
>                         <subviews>
>                             <tableView verticalHuggingPriority="750" allowsExpansionToolTips="YES" alternatingRowBackgroundColors="YES" columnReordering="NO" multipleSelection="NO" emptySelection="NO" autosaveName="sprefs_hotkeys_view" headerView="3541" id="2670">
> -                                <rect key="frame" x="0.0" y="0.0" width="527.5" height="19"/>
> +                                <rect key="frame" x="0.0" y="0.0" width="528" height="19"/>
>                                 <autoresizingMask key="autoresizingMask"/>
>                                 <animations/>
>                                 <size key="intercellSpacing" width="3" height="2"/>
> @@ -1809,7 +1809,6 @@ Gw
>                                     </tableColumn>
>                                 </tableColumns>
>                                 <connections>
> -                                    <action selector="hotkeySettingChanged:" target="-2" id="ica-hO-RYk"/>
>                                     <outlet property="dataSource" destination="-2" id="C8J-sb-AP6"/>
>                                     <outlet property="delegate" destination="-2" id="wjB-fD-pTb"/>
>                                 </connections>
> -- 
> 2.2.1

Hi,

Merged, thanks. For next patches, please add a „macosx:“ prefix for intf changes in the commit message. I just modified this patch manually.

Best,
David