[vlc-devel] [PATCH] macosx: Refactor MainWindow class for better code-style consistency

Felix Paul Kühne fkuehne at videolan.org
Thu Sep 24 15:03:42 CEST 2015


> On 24 Sep 2015, at 14:57, David Fuhrmann <david.fuhrmann at gmail.com> wrote:
> 
> 
> 2015-09-24 13:54 GMT+02:00 Felix Paul Kühne <fkuehne at videolan.org>:
> 
> > On 24 Sep 2015, at 13:43, epirat07 at gmail.com wrote:
> >
> > From: Marvin Scholz <epirat07 at gmail.com>
> >
> > Most of the IBOutlets that used Hungarian notation are renamed and
> > the bindings in the MainWindow.xib were adjusted accordingly.
> > Removed spacing in front of arguments in Objective C methods.
> > Replace another unnecessary iteration used for source list item
> > expansion.
> 
> Does it make sense to use _xxx as variable names (or properties like we use them in newer code)?

Yep, indeed, properties would make sense here as well.

Best regards,

Felix


More information about the vlc-devel mailing list