[vlc-devel] [PATCH 3/3] demux: fix missing pf_ return code

[Rémi Denis-Courmont]

Le 2015-09-25 17:46, Francois Cartegnie a écrit :
> 1 was success
> ---
>  include/vlc_demux.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/vlc_demux.h b/include/vlc_demux.h
> index 2c8e668..7bbf55a 100644
> --- a/include/vlc_demux.h
> +++ b/include/vlc_demux.h
> @@ -202,7 +202,7 @@ VLC_API int demux_vaControlHelper( stream_t *,
> int64_t i_start, int64_t i_end,
>  VLC_USED static inline int demux_Demux( demux_t *p_demux )
>  {
>      if( !p_demux->pf_demux )
> -        return 1;
> +        return VLC_DEMUXER_EGENERIC;

Did you actually TEST this? I'm pretty sure it breaks.

>
>      return p_demux->pf_demux( p_demux );
>  }

-- 
Rémi Denis-Courmont
http://www.remlab.net/