[vlc-devel] [PATCH] http: Mark the http-reconnect option as plugin-safe
lu_zero at gentoo.org
Sat Sep 26 20:16:17 CEST 2015
On 26/09/15 18:57, Rémi Denis-Courmont wrote:
> Le 2015-09-26 19:44, Luca Barbato a écrit :
>> On 26/09/15 12:34, Rémi Denis-Courmont wrote:
>>> TBH, I would much prefer obsoleting the option and reconnecting
>>> automatically when appropriate (i.e. connection broken before known end
>>> of file).
>> I might try to find some time to do that later, that would require to:
>> - have the fact the connection is broken reported by the lower layer
>> - get the expected end of file or know that the file doesn't have an end.
>> In the mean time I'd merge it and get some plugin users happier.
>> Would it be ok?
> Exposing http-reconnect to playlist and then removing it later is not a
> good idea. I am also not convinced that allowing random playlist files
> to enable http-reconnect against third party web servers is a good idea
I think for the plugin users it makes sense to have it, no matter what,
anyway if you really adamant I'll try to get the file size and reconnect
if I get an EOF when the size is not the expected.
Would that be acceptable for you?
More information about the vlc-devel