[vlc-devel] [PATCH 06/11] playlist/directory: attach slaves to input items

[Steve Lhomme]

On Mon, Apr 4, 2016 at 7:34 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> On Monday 04 April 2016 19:15:39 Thomas Guillem wrote:
>> On Sat, Apr 2, 2016, at 11:32, Rémi Denis-Courmont wrote:
>> > Direct comparison works for file paths, not for URIs. Ditto in the
>> > existing
>> > code above.
>>
>> I see 2 solutions:
>>  - Convert psz_uri to a vlc_url_t and do our cmp operations on
>>  url->psz_path
>
> The path portion of a URL is not directly comparable either, and even if it
> were, it would be insufficient to perform the comparison. As far as I know,
> you cannot compare URLs, at least not in a generic scheme-independent manner.
>
>>  - Add a psz_filepath in input_item_t. Directory demuxers will be able
>>  to set a path and an uri.
>
> Not all URI scheme have a file path.  And I fail to see how that enables
> comparisons anyway.

What is the issue here ? Do we want to avoid false positive slaves or
false negative salves ? I'd assume we want to avoid false positive and
a basic string comparison avoids that.

> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel