[vlc-devel] [PATCH 06/11] playlist/directory: attach slaves to input items

Rémi Denis-Courmont remi at remlab.net
Tue Apr 5 19:49:53 CEST 2016


Le 2016-04-05 18:53, Thomas Guillem a écrit :
> On Tue, Apr 5, 2016, at 10:17, Rémi Denis-Courmont wrote:
>> Le 2016-04-05 08:22, Steve Lhomme a écrit :
>> > What is the issue here ? Do we want to avoid false positive slaves 
>> or
>> > false negative salves ? I'd assume we want to avoid false positive
>> > and
>> > a basic string comparison avoids that.
>>
>> strcmp() on URIs is subject to both false positives and false
>> negatives.
>
> What about doing a comparaison of p_item->psz_name (only if it has an
> extension) ?

Uh? psz_name is a human-readable meaningless string. AFAIK, it is 
routinely modified while preparsing, so relying on it is insane.


-- 
Rémi Denis-Courmont
http://www.remlab.net/


More information about the vlc-devel mailing list