[vlc-devel] [PATCH 06/11] playlist/directory: attach slaves to input items

Steve Lhomme robux4 at gmail.com
Wed Apr 6 08:49:57 CEST 2016


On Wed, Apr 6, 2016 at 8:41 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> On 06 Apr, Steve Lhomme wrote :
>> On Tue, Apr 5, 2016 at 11:09 PM, Benjamin Adolphi <b.adolphi at gmail.com> wrote:
>> > Ok, so I realize that it is complicated or probably even impossible to
>> > compare URLs in a scheme-independent manner. So what about limiting
>> > scope? We don't really want to compare any kind of URL against any
>> > other kind of URL. What we want to do is compare filenames and file
>> > extensions. So we can of course not do this with URLs that do not have
>> > a path. So let's limit which schemes we support to schemes that
>> > actually have a path (and that VLC actually supports).
>> >
>> > In addition, if we are afraid of comparing URLs with different schemes
>> > (I am not sure if this is potentially problematic), we can also limit
>> > the comparison to only compare URLs with the same scheme. Since we are
>> > adding the slaves from the directory demuxer, the slaves and the input
>> > item will have have URLs with the same scheme anyways.
>>
>> I'd like to know when string comparison of 2 URIs can produce false
>> positive. How can "scheme://host:port/path" point to different data
>> than "scheme://host:port/path" ? Or is it because of the possible
>
> Can't it happen if host are different but pointing to the same IP?

Yes but in the case of subtitle lookup I don't think we should use
such a file. So if the strcmp() fails we wouldn't use it.

> With my kindest regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list