[vlc-devel] [PATCH 3/3] packetizer: h264: fill colour_desc if present

[Thomas Guillem]

On Sat, Apr 16, 2016, at 15:07, Francois Cartegnie wrote:
> Le 16/04/2016 14:58, Thomas Guillem a écrit :
> >              /* colour desc */
> >              i_tmp = bs_read( p_bs, 1 );
> >              if ( i_tmp )
> > -                bs_read( p_bs, 24 );
> > +            {
> > +                p_sps->vui.colour_desc.b_valid = true;
> 
> There's no such "Valid" state.
> It's either present or inferred if you plan to use them.
> See VUI semantics.

For HEVC it's done differently, but for H264 I used the same semantics:
    if( i_tmp )
    {
        p_sps->vui.b_valid = true;

no?

> 
> > +                p_sps->vui.colour_desc.i_colour_primaries = bs_read( p_bs, 8 );
> > +                p_sps->vui.colour_desc.i_transfer_characteristics = bs_read( p_bs, 8 );
> > +                p_sps->vui.colour_desc.i_matrix_coefficients = bs_read( p_bs, 8 );
> > +            }
> 
> 
> Francois
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel