[vlc-devel] [PATCH 1/2] [RFC] core: add a demux-filter similar to stream-filter for demuxers

[Rémi Denis-Courmont]

On Saturday 23 April 2016 15:21:24 Steve Lhomme wrote:
> On Sat, Apr 23, 2016 at 11:27 AM, Rémi Denis-Courmont <remi at remlab.net> 
wrote:
> > On Friday 22 April 2016 17:57:20 Steve Lhomme wrote:
> >> it allows filtering the Demux calls to the underlying muxer
> >> it can be chained like stream-filters
> >> internally it's a regular demuxer_t with the p_source demuxer set
> >> 
> >> the base value of "demux-filter" is set in libvlc, each input_thread_t
> >> has
> >> their own copy
> >> 
> >> diff --git a/include/vlc_demux.h b/include/vlc_demux.h
> >> index 45f5416..0dcee90 100644
> >> --- a/include/vlc_demux.h
> >> +++ b/include/vlc_demux.h
> >> @@ -77,6 +77,10 @@ struct demux_t
> >> 
> >>      /* Weak link to parent input */
> >>      input_thread_t *p_input;
> >> 
> >> +
> >> +    /* for demux-filter */
> >> +    demux_t *p_source;
> > 
> > union with s.
> > 
> >> +    config_chain_t *p_cfg;
> > 
> > This is pointless. A demux can´t spawn a chain.
> > 
> > Also I don´t get how the filter is supposed to pass on ES output requests,
> > and direct accesses from access/stream/demux to p_input.
> 
> That's "reserved" to the master demuxer. It's at the end of the demuxer
> chain.

No way. Been there done that.

-- 
Rémi Denis-Courmont
http://www.remlab.net/