[vlc-devel] [PATCH] Fix Hurd build

Samuel Thibault samuel.thibault at ens-lyon.org
Tue Apr 26 20:27:13 CEST 2016


Rémi Denis-Courmont, on Tue 26 Apr 2016 10:00:39 +0200, wrote:
> >+    long path_max = pathconf (".", _PC_PATH_MAX);
> >+    size_t maxsize = (path_max == -1 || path_max > 4096) ? 4096 :
> >path_max;
> >+    char  fname[BLOCKSIZE + maxsize];
> 
> Looks like we have a stack buffer overflow here, with or without the patch.

You mean because PATH_MAX is big?  Right, I have turned that into
dynamic allocation.

Samuel


More information about the vlc-devel mailing list