[vlc-devel] [PATCH] Fix Hurd build

Denis Charmet typx at dinauz.org
Wed Apr 27 12:10:54 CEST 2016


On 2016-04-26 21:14, Samuel Thibault wrote:
> Rémi Denis-Courmont, on Tue 26 Apr 2016 22:12:04 +0300, wrote:
>> I mean the following sprintf(). Maybe there was a nonobvious way to 
>> prevent
>> overflow, but I don´t see it.
> 
> Ok. The "idea" behind PATH_MAX is that it's supposed to be the maximum
> size you'd want to pass with prefix and filename. But yes, that won't
> prevent anybody from actually passing bigger filenames, and so the
> second patch I sent, which uses malloc, just avoids the issue 
> altogether.

I think the point of Rémi was: use snprintf and not sprintf regardless 
of your memory zone of allocation.

Regards,
-- 
Denis Charmet - TypX
Le mauvais esprit est un art de vivre


More information about the vlc-devel mailing list