[vlc-devel] [vlc-commits] input/demux: make helper type more generic

Filip Roséen filip at atch.se
Tue Aug 2 17:29:17 CEST 2016

Attached is a patch that hopefully resolves this issue as it is addressed;
a review is more than welcome!

On 16/08/02 17:07, Filip Roséen wrote:

> Hi Remi,
> On 16/08/02 16:26, Rémi Denis-Courmont wrote:
> > >vlc | branch: master | Filip Roséen <filip at atch.se> | Sat Jul 30
> > > ...
> > >This commit changes both the name of the type, but also its data-members, so
> > >that it is more generic. As the lookup maps will always be initialized with
> > >string-literals, there is no need to specify an explicit size for the
> > >data-members; instead we can simply rely on a pointer-to-char.
> > 
> > This effectively reverts 6b9308c8f6a66a2f10f1a201490b0be396f2bbfd without discussion.
> > 
> > I wholly disagree here.
> I must apologize for not looking through the git log for the relevant code
> segment more carefully before writing those changes; I will of course look
> into the matter and provide a fix for it as soon as possible.
> Thank you for letting me know.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160802/f4ada295/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: input-demux-fix-accidental-revert-of-6b9308.patch
Type: text/x-diff
Size: 1027 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160802/f4ada295/attachment.patch>

More information about the vlc-devel mailing list