[vlc-devel] [vlc-commits] configure.ac: Use AC_PATH_PROGS for luac

[Rémi Denis-Courmont]

Le 2016-08-03 14:14, git at videolan.org a écrit :
> vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Wed
> Aug  3 12:18:15 2016 +0200| 
> [454d683bc147cf48e067165ec703f19320818430]
> | committer: Hugo Beauzée-Luyssen
>
> configure.ac: Use AC_PATH_PROGS for luac
>
> Signed-off-by: Rafaël Carré <funman at videolan.org>
>
>> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=454d683bc147cf48e067165ec703f19320818430
> ---
>
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 3bd40d4..62e62b8 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1562,7 +1562,7 @@ then
>        AC_MSG_ERROR([Could not find lua. Lua is needed for some
> interfaces (rc, telnet, http) as well as many other custom scripts.
> Use --disable-lua to ignore this error.])
>    fi
>    AC_ARG_VAR([LUAC], [LUA byte compiler])
> -  AC_CHECK_PROGS(LUAC, [${LUAC} luac], [false])
> +  AC_PATH_PROGS(LUAC, [${LUAC} luac], [false])

Why? We don't normally use full path for build tools in general, and 
compilers in particular.

(I don't need to mention that the build process assumes the same 
environment in ./configure and in make. Far too many variables have side 
effects in the build process otherwise.)


Rémi Denis-Courmont
http://www.remlab.net/