[vlc-devel] [vlc-commits] configure.ac: Use AC_PATH_PROGS for luac

[Rémi Denis-Courmont]

Le 2016-08-03 15:52, Rafaël Carré a écrit :
> On 08/03/2016 03:49 PM, Hugo Beauzée-Luyssen wrote:
>> On 08/03/2016 03:46 PM, Rafaël Carré wrote:
>>> On 08/03/2016 03:43 PM, Hugo Beauzée-Luyssen wrote:
>>>
>>>> I have no problem reverting this patch, but I'd like to have an
>>>> alternative solution which doesn't involve installing luac system 
>>>> wide
>>>> before compiling.
>>>
>>> export PATH=$vlc/contrib/`gcc -dumpmachine`/bin:$PATH
>>> ./configure
>>> make
>>
>> That would work, but is cumbersome to some extent.
>> And if this is the expected way, why bother changing the PATH
>> temporarily during configure in the first place?
>
> I agree, if this path is removed, changing PATH in configure.ac 
> should
> be removed as well.

It should be removed regardless. Adding extras/tools to PATH in 
configure is an ugly kludge. Adding contribs to PATH in configure is 
just plain wrong.

-- 
Rémi Denis-Courmont
http://www.remlab.net/