[vlc-devel] [PATCH] access: live555: fix spurious PCR_RESET on RTCP clock synchronization

[Rémi Denis-Courmont]

Le perjantaina 5. elokuuta 2016, 23.41.28 EEST Francois Cartegnie a écrit :
> ---
>  modules/access/live555.cpp | 61
> +++++++++++++++++++++++++++++++++------------- 1 file changed, 44
> insertions(+), 17 deletions(-)
> 
> diff --git a/modules/access/live555.cpp b/modules/access/live555.cpp
> index bc5a9fa..019a48c 100644
> --- a/modules/access/live555.cpp
> +++ b/modules/access/live555.cpp
> @@ -165,8 +165,10 @@ typedef struct
>      unsigned int    i_buffer;
> 
>      bool            b_rtcp_sync;
> +    bool            b_discontinuity;
>      char            waiting;
>      int64_t         i_pts;
> +    int64_t         i_pcr;
>      double          f_npt;

RTP has only one set of timestamp(s) per stream (i.e. track). Keeping track of 
a second timestamp value does not make sense.

And the only way to avoid resetting the PCR on first RTCP sync is to wait for 
RTCP sync, in other words assuming the server has a clue and implements 
RFC6051 or something similar.

-- 
Rémi Denis-Courmont
http://www.remlab.net/