[vlc-devel] [PATCH 3/4] Qt: refactor vout resize

[Jean-Baptiste Kempf]

On 07 Aug, Анатолий Аниськович wrote :
> Qt use signed integers for sizing everywhere. Narrowing down number of
> casts and compiler warnings.

The core gives unsigned int. Use unsigned int.

> > How can you remove all that and not break everything?
> 
> sizeChanged triggers resize, thus, few more geometry recalculations.
> Idea is to avoid resizing by ourself and trust the parent
> widget/layout to provide correct size. That's why we need custom size
> hint and size policy.

But the parent layout does not provide correct size! That's the point!
Qt lies about the size().

And you remove comments about clearly explained bugs!

So, until this patch is better tested, I can't apply this.


-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device