[vlc-devel] [PATCH] contrib: add aom (default disabled)

[Rémi Denis-Courmont]

Le tiistaina 23. elokuuta 2016, 10.24.57 EEST Tristan Matthews a écrit :
> Hi,
> 
> On Tue, Aug 23, 2016 at 5:28 AM,  <remi at remlab.net> wrote:
> > Hello,
> > 
> > Why do you disable hashing the source? That should be an automatic
> > negative
> > ack IMO.
> 
> This contrib package isn't pinned to a specific hash, but rather the
> latest git HEAD.

That should also be an automatic nack. If we don´t control the source code, we 
can´t ensure that builds is reproducible (in any reasonable extent) if you do 
that. And we can hardly even meet our legal obligations under the (L)GPL.

> Normally I'd switch to a pinned version after an aom
> release and/or default-enabling this contrib. FWIW, we also skip
> hashing the sources for: bghudappkit, daala (disabled), ffmpeg,
> fluidlite, mfx, mpcdec, postproc, x264, x26410b and x262.

ffmpeg and x264 are not hashed because of hysterical raisins. The rest is 
inexcusable sloppiness, sorry.

-- 
Rémi Denis-Courmont
http://www.remlab.net/