[vlc-devel] [vlc-commits] daala: fix linking

[Tristan Matthews]

On Wed, Aug 24, 2016 at 7:22 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le tiistaina 23. elokuuta 2016, 9.55.49 EEST Tristan Matthews a écrit :
>> vlc | branch: master | Tristan Matthews <tmatth at videolan.org> | Tue Aug 23
>> 03:49:39 2016 -0400| [b7c57ac1ecb355d191321f46427c7696354308e3] |
>> committer: Tristan Matthews
>>
>> daala: fix linking
>>
>> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=b7c57ac1ecb355d1913
>> > 21f46427c7696354308e3
>> ---
>>
>>  modules/codec/Makefile.am | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/modules/codec/Makefile.am b/modules/codec/Makefile.am
>> index c42473b..4e3ba6d 100644
>> --- a/modules/codec/Makefile.am
>> +++ b/modules/codec/Makefile.am
>> @@ -281,7 +281,7 @@ codec_LTLIBRARIES += $(LTLIBtheora)
>>  libdaala_plugin_la_SOURCES = codec/daala.c
>>  libdaala_plugin_la_CFLAGS = $(AM_CFLAGS) $(DAALA_CFLAGS)
>>  libdaala_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(codecdir)'
>> -libdaala_plugin_la_LIBADD = $(DAALA_LIBS)
>> +libdaala_plugin_la_LIBADD = $(DAALA_LIBS) $(LIBM)
>
> I can´t see any maths symbol used in daala.c. In fact, <math.h> is not even
> included there. That patch does not seem right.

Yeah, my mistake, the issue is in contrib, not the module.

>
>>  EXTRA_LTLIBRARIES += libdaala_plugin.la
>>  codec_LTLIBRARIES += $(LTLIBdaala)
>>
>>
>> _______________________________________________
>> vlc-commits mailing list
>> vlc-commits at videolan.org
>> https://mailman.videolan.org/listinfo/vlc-commits
>
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel