[vlc-devel] [PATCH 1/2] libvlc: deactivate the playlist before destroying the preparser

Rémi Denis-Courmont remi at remlab.net
Thu Aug 25 15:19:08 CEST 2016


Le torstaina 25. elokuuta 2016, 14.53.21 EEST Filip Roséen a écrit :
> There are cleaner solutions, and I plan to send such as RFC to
> `vlc-devel` later this week.
> On 16/08/24 20:11, Rémi Denis-Courmont wrote:
> > > In that case we need to split it up into 1) deactivate playlist 2)
> > > destroy interfaces (but not the playlist) 3) delete the preparser 4)
> > > delete the playlist (idea from filip).
> > 
> > I don´t know. I don´t understand the relevance of step (1) and of this
> > patch to the underlying problem.
> The relevance of step `(1)` is basically to make sure that something
> does not schedule a *preparse-request*

That´s what I don´t understand. How is deactivating the playlist, i.e. 
shutting down the playlist thread, making a difference here?

> inbetween `(3)` and `(4)`
> without introducing too many changes to the preparser process itself.

I don´t actually think that there is anything wrong with the preparser in the 
first place. The playlist fails to deregister its callbacks; the root cause of 
the bug lies in the playlist, not the preparser.

> It can however be solved in different manners, I just thought of the
> steps to reach a simple solution to a rather complex problem (given
> the current implementation).

Rémi Denis-Courmont

More information about the vlc-devel mailing list