[vlc-devel] [PATCH 06/19] ttml codec: add tag style parsing support

[Francois Cartegnie]

Le 29/08/2016 à 23:01, Stanislas Plessia a écrit :

> +            if( !strcasecmp( psz_node_name, "style" ) || !strcasecmp( psz_node_name, "tt:style" ) ||
> +                !strcasecmp( psz_node_name, "region" ) || !strcasecmp( psz_node_name, "tt:region" ) )

Following a comment on a previous patch,
Unless TTML enforces use of dedicated prefixes, that's only correct for
most seen cases.

> +                if( p_style == NULL )
> +                {
> +                    msg_Warn( p_dec, "Style \"%s\" not found", token );

nitpicking, dumps the whole remaining tokens.

Unsure we should stop parsing.

> +                    free( value );
> +                    break;
> +                }
> +

Francois