[vlc-devel] [vlc-commits] bonjour: Work around a macOS 10.12 bug

[Marvin Scholz]

On 7 Dec 2016, at 18:42, Felix Paul Kühne wrote:

> Hey Marvin,
>
>> On 06 Dec 2016, at 10:26, Marvin Scholz <git at videolan.org> wrote:
>>
>> diff --git a/modules/services_discovery/bonjour.m 
>> b/modules/services_discovery/bonjour.m
>> index cd9cb3a..3181fbf 100644
>> --- a/modules/services_discovery/bonjour.m
>> +++ b/modules/services_discovery/bonjour.m
>> @@ -207,6 +207,10 @@ NSString *const VLCBonjourRendererDemux         
>> = @"VLCBonjourRendererDemux";
>> {
>>     [_serviceBrowsers makeObjectsPerformSelector:@selector(stop)];
>>
>> +    /* Work around a macOS 10.12 bug, see 
>> https://openradar.appspot.com/28943305 */
>> +    [_serviceBrowsers 
>> makeObjectsPerformSelector:@selector(setDelegate:) withObject:nil];
>> +    [_resolvedNetServices 
>> makeObjectsPerformSelector:@selector(setDelegate:) withObject:nil];
>> +
>
> If this behavior is really limited to 10.12, maybe the work-around 
> should be applied on that OS release only, too?

Are there any downsides of doing it regardless of the OS version?

I was not able to test with any other version except 10.12 so I m not 
sure if it really only affects 10.12, but given
that the Chromium ticket says so, I guess it does.

> Cheers,
>
> Felix
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel