[vlc-devel] [PATCH 1/2] playlist/preparser: do not "download" local art

[Filip Roséen]

Hi Remi,

On 2016-12-08 20:17, Rémi Denis-Courmont wrote:

> Le torstaina 8. joulukuuta 2016, 11.14.19 EET Filip Roséen a écrit :
> > The previous implementation would consider FILE:///art.jpg to be a
> > remote resources, meaning that it would try to "download" the file and
> > put it in the cache.
> > 
> > Given that the scheme part of an URI is case-insensitive (as stated in
> > RFC3986 3.1.), these changes make sure that we treat the affected
> > schemes in the way which was intended.
> 
> It feels like dancing around the problem. Some file URIs are not local 
> (network file systems, user-space file systems), or are slow to access. Also a 
> number of other URI schemes are not networked and do not need to be cached.

I fully agree with you.

I have been thinking about adding a way for *accessor* to say whether
or not they are in the "network" category of accessing entities. The
problem is of course, as you say, that there are resources that might
look like local entities, but are actually (for all intents and
purposes) remote.

It would however make the implementation a little more robust, by
simply not queriny for *accessors* that are known to establish, as an
example, *TCP* connections.

 - Do you have any additional thoughts on how to address the issue?

Best Regards,\
Filip
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161209/0b7710a9/attachment.html>