[vlc-devel] [PATCH 2/2] playlist/fetcher: do not ignore metadata scope when downloading art

Pierre Ynard linkfanel at yahoo.fr
Sat Dec 10 01:08:45 CET 2016

> Previously the implementation would unconditionally download art,
> these changes make sure that we respect the scope of the fetcher being
> used.

Does this mean that the Art URL returned by any lua playlist script
suddenly gets ignored? There will be complaints about that, and it
hardly makes sense since typical scripts parse a web page resulting from
deliberate network access, and are allowed by design to make secondary
network requests to fetch the media URL and other metadata.

I agree that privacy leaks are to be taken seriously, but even in the
M3U example, you could argue the appropriate and intuitive behavior is
to still download the art, if the URL of the main media and/or of the
M3U is already on the network.

I don't know well enough the playlist and art code to make
recommendations, but I'll suggest to adjust the scope flags if the
original request already has a larger scope than the metadata setting;
or maybe just a check comparing the URL protocols would be an easy way
to offer a lot of functionality.

Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."

More information about the vlc-devel mailing list