[vlc-devel] [PATCH 12/13] vout/opengl: add a new API to configure fragment shaders

Filip Roséen filip at atch.se
Tue Dec 13 17:40:49 CET 2016

Hi Wilawar,

For starters I can once again say that your formatting causes your
emails to be hard to read; please see other messages on the
*mailing-list* for further information.

If you want aid in how to format your replies, just ask in `#videolan`
(though I am not sure how much more information can be given on the

On 2016-12-13 17:08, Wilawar wrote:

> I hope the format I’ve chosen this time will be more readable to
> you. Let me know whether you’re interested in proof-reading plain
> English at all.

Fixing grammatical errors can of course be addressed by submitting a
relevant patch to `vlc-devel`. I am also not sure what you mean by
"copying out the patch"; `git am` works with emails just fine,
especially given that that is what it is designed to work with.

See the below linked resource for more information:

 - https://git-scm.com/docs/git-am

> I also hope that you understand that I neither think this could have
> been handled by RFC patches in any sensible way nor that I really
> want to go through copying out the patch, creating a file for it,
> applying it in Git (especially since it won’t necessarily apply on
> its own as it’s part of a series), followed by eight turns of
> changing a few characters (once for every change), doing a
> format-patch, copying it over and wrapping it up, then sending an
> eight part RFC series of nitpick changes to a single patch. (Also
> called spamming.) ;)

If your email client does not support downloading the emails in an
easy manner, I would recommend checking out the *bundle* feature at

Below is a bundle that I created for the relevant patches (notice the
*"Download bundle as email"* at the very top):

 - https://patches.videolan.org/bundle/FilipRoseen-refp/tguillem-opengl/

`git` is a marvelous tool, and doing what you describe is not
complicated at all.

 1. `git am` the bundles
 2. Change what you want to change
 3. Commit your changes (in relevant, individual, commits)
 4. `git format-patch`
 5. Reply to the relevant patches on `vlc-devel` with your patches
    as attachment.

There is no point complaining about the workflow, we all do it; and
the only one really complaining about it (for the last couple of
months) are you. 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161213/24f26802/attachment.html>

More information about the vlc-devel mailing list