[vlc-devel] [PATCH] [RFC] video output:win32: use the direct3d11 vout when d3d11va is selected

[Steve Lhomme]

On Tue, Dec 13, 2016 at 5:27 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> Hello,
>
>
> On Tue, 13 Dec 2016, at 17:20, Steve Lhomme wrote:
>> -    set_capability("vout display", 240)
>> +    set_capability("vout display", 275)
>
> Please check that we do respect b7e1db84295007a76e585ec6590bd9a75f1e3006

Given these ranges we don't change category here.

> and 378ac85a61b3d0aed82eae2177287a899699de2b.

Yes the SPU blending is done by the GPU not in software.

> Do we have correct spu blending ?

Yes. We can display NV12 and RGBA textures at the same time. They use
their own pixel shader.

>> +#ifdef HAVE_D3D11_H
>> +    if (vd->source.i_chroma == VLC_CODEC_D3D11_OPAQUE)
>> +        goto error;
>> +#endif
>
> Why the ifdef?

That's what the title say. If you select d3d11va and don't enforce the
vout, d3d9 is picked and so a conversion (d3d11_surface) is used. So
we can refuse this kind of input, as long as the d3d11 vout is known
to be present/compiled. It will fallback to d3d11 (once we have pushed
its priority above opengl).

> Why is it in the same commit as above?

They are related, although it could be split in 2. The latter coming second.

> --
> Jean-Baptiste Kempf -  President
> +33 672 704 734
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel