[vlc-devel] [PATCH 1/2] vlc_fixups: fix crash when NULL is passed to strdup() on OS/2

[Thomas Guillem]

On Thu, Dec 22, 2016, at 05:26, KO Myung-Hun wrote:
> Attach the patch.
> 
> KO Myung-Hun wrote:
> > Hi/2.
> > 
> > Francois Cartegnie wrote:
> >> Le 20/12/2016 à 13:37, KO Myung-Hun a écrit :
> >>> On OS/2, strdup() crashes if NULL is passed.
> >>
> >> No.
> >> Fix the cause, not the expected effect.
> >>
> > 
> > I looked into this further, and found the cause.
> > 
> > FromCharset() in ExtractIntlStrings() of demux/mp4/meta.c returns NULL.
> > At that time, charset is "MACINTOSH//eng" and i_lang is 0.
> > 
> > MACINTOSH//eng is a correct charset ? libiconv installed on my machine
> > does not understand it.
> > 
> 

Hi, I already fixed this crash yesterday
http://git.videolan.org/?p=vlc.git;a=commit;h=6fca9f1489ff97fb5722baceeffa451efffddae3

> -- 
> KO Myung-Hun
> 
> Using Mozilla SeaMonkey 2.7.2
> Under OS/2 Warp 4 for Korean with FixPak #15
> In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM
> 
> Korean OS/2 User Community : http://www.ecomstation.co.kr
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> Email had 1 attachment:
> + 0001-demux-mp4-try-again-with-a-default-charset-if-FromCh.patch
>   1k (application/x-patch)