[vlc-devel] [PATCH] access/sftp: authenticate with ssh-agent access/sftp: check libssh2_userauth_list for available auth methods

Jean-Baptiste Kempf jb at videolan.org
Mon Dec 26 16:30:22 CET 2016


Hello,

On Fri, 2 Dec 2016, at 02:41, git at yidong.im wrote:
> +    p_sshagent = libssh2_agent_init( p_sys->ssh_session );
> +    if( !p_sshagent )
> +    {
> +        msg_Dbg( p_access, "Failed to initialize key agent" );
> +        goto agent_bailout;
> +    }
> +agent_bailout:
> +    libssh2_agent_disconnect( p_sshagent );

This will crash, by dereferencing NULL.

Please fix.

-- 
Jean-Baptiste Kempf -  President
+33 672 704 734


More information about the vlc-devel mailing list