[vlc-devel] [PATCH] vpx: treat unsupported bitstream error as fatal

[Tristan Matthews]

On Mon, Dec 26, 2016 at 11:06 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> What about at configure time?

I think you can only tell if the encoder is configured for high bit
depth, not the decoder. So if you checked the encoder capabilities
(assuming that the encoder was even built), you could deduce that the
decoder could decode high bit depth, but otherwise there's no way of
knowing until you start decoding.

Best,
Tristan

>
> On Mon, 26 Dec 2016, at 17:04, Tristan Matthews wrote:
>> Hi,
>>
>> On Mon, Dec 26, 2016 at 10:22 AM, Jean-Baptiste Kempf <jb at videolan.org>
>> wrote:
>> > Hello,
>> >
>> > Why does it not fail in Open() then?
>>
>> AFAIK there's no way of checking if your decoder was built with high
>> bitdepth support, maybe there's a way of probing in Open() that
>> escapes me.
>>
>> Best,
>> Tristan
>>
>> >
>> > On Fri, 23 Dec 2016, at 05:06, Tristan Matthews wrote:
>> >> Otherwise it will keep trying to decode blocks that the library is
>> >> incapable of decoding (e.g., 10-bit without --enable-vp9-highbitdepth).
>> >> ---
>> >>  modules/codec/vpx.c | 2 ++
>> >>  1 file changed, 2 insertions(+)
>> >>
>> >> diff --git a/modules/codec/vpx.c b/modules/codec/vpx.c
>> >> index 15e3a27048..ea70172cde 100644
>> >> --- a/modules/codec/vpx.c
>> >> +++ b/modules/codec/vpx.c
>> >> @@ -191,6 +191,8 @@ static picture_t *Decode(decoder_t *dec, block_t
>> >> **pp_block)
>> >>      if (err != VPX_CODEC_OK) {
>> >>          free(pkt_pts);
>> >>          VPX_ERR(dec, ctx, "Failed to decode frame");
>> >> +        if (err == VPX_CODEC_UNSUP_BITSTREAM)
>> >> +            dec->b_error = true;
>> >>          return NULL;
>> >>      }
>> >>
>> >> --
>> >> 2.11.0
>> >>
>> >> _______________________________________________
>> >> vlc-devel mailing list
>> >> To unsubscribe or modify your subscription options:
>> >> https://mailman.videolan.org/listinfo/vlc-devel
>> >
>> >
>> > --
>> > Jean-Baptiste Kempf -  President
>> > +33 672 704 734
>
>
> --
> Jean-Baptiste Kempf -  President
> +33 672 704 734