[vlc-devel] [PATCH 2/2] picture_pool: fix Reserve() not locking/unlocking pictures

[Thomas Guillem]

On Fri, Dec 30, 2016, at 20:32, Rémi Denis-Courmont wrote:
> Le vendredi 30 décembre 2016, 17:58:21 Thomas Guillem a écrit :
> > Pictures cloned from a reserved pool were not locked/unlocked via the master
> > pool callbacks. This commit fixes this issue. See the new comment in
> > picture_pool_Reserve().
> 
> Whether this is a feature or a bug depends on how you intend to use 
> lock/unlock.
> 
> I am not aware of clear defined semantics at the moment, that video
> output 
> displays would actually adhere to, and thus I think that this patch is
> both 
> right and wrong depending on the back-end. Or rather, the correctness
> cannot 
> be evaluated for lack of criteria.
> 
> More importantly, I cannot think of any use case for using the lock and
> unlock 
> callbacks, that would be both practically useful for the display plugin,
> and 
> safe/valid/well-defined, so I don't really see the point in these extra 
> intricacies.

My work in progress OpenGL PBO branch
https://github.com/tguillem/vlc/commit/bf7fa65ede8fb10839f70d61f707965ee43b6049
will need this commit.

PBO for Pixel Buffer Object.  With that, we can do direct rendering with
OpenGL x / OpenGLES 3 display modules. For now, perfs are worse with
OpenGLES 3 but 30% better (for 4K) with OpenGL (still WIP).

With this current pbo patch, I really need pictures to be unlocked after
a call to prepare/display.

> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel