[vlc-devel] [PATCH 2/2] picture_pool: fix Reserve() not locking/unlocking pictures
thomas at gllm.fr
Fri Dec 30 23:13:21 CET 2016
On Fri, Dec 30, 2016, at 20:32, Rémi Denis-Courmont wrote:
> Le vendredi 30 décembre 2016, 17:58:21 Thomas Guillem a écrit :
> > Pictures cloned from a reserved pool were not locked/unlocked via the master
> > pool callbacks. This commit fixes this issue. See the new comment in
> > picture_pool_Reserve().
> Whether this is a feature or a bug depends on how you intend to use
> I am not aware of clear defined semantics at the moment, that video
> displays would actually adhere to, and thus I think that this patch is
> right and wrong depending on the back-end. Or rather, the correctness
> be evaluated for lack of criteria.
> More importantly, I cannot think of any use case for using the lock and
> callbacks, that would be both practically useful for the display plugin,
> safe/valid/well-defined, so I don't really see the point in these extra
My work in progress OpenGL PBO branch
will need this commit.
PBO for Pixel Buffer Object. With that, we can do direct rendering with
OpenGL x / OpenGLES 3 display modules. For now, perfs are worse with
OpenGLES 3 but 30% better (for 4K) with OpenGL (still WIP).
With this current pbo patch, I really need pictures to be unlocked after
a call to prepare/display.
> Rémi Denis-Courmont
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
More information about the vlc-devel