[vlc-devel] [PATCH] subtitles: don't force double directory separators

Rémi Denis-Courmont remi at remlab.net
Mon Feb 1 11:12:29 CET 2016

Le 2016-02-01 11:22, Steve Lhomme a écrit :
> On Sat, Jan 30, 2016 at 3:47 PM, Rémi Denis-Courmont 
> <remi at remlab.net> wrote:
>> Le 2016-01-30 10:26, Steve Lhomme a écrit :
>>> From: Steve Lhomme <robUx4 at gmail.com>
>>> WindowsPhone doesn't like double backslashes in the path
>> I think you are hosed then. It's most certainly not the only place 
>> where
>> paths get concatenated.
> Should we make helper functions to concatenate pathes ? Or maybe a
> path cleaner helper ?

I don't know and I really don't care. I doubt you can make a helper 
that addresses most cases, is easy to use and does not introduce new 
error cases.

>> Also complicated string handling in C is best avoided.
> I agree but I don't think switching to another language is an option.

I don't think adding new string manipulation, memory allocation and 
error handling code in a lot of file paths, file URIs and file-like URI 
is an option either. The risk of leaks and bugs, including security 
issues, and the cost on the community of developers who don't care about 
Windows mobile, are high.

This is the same argument as OS/2 not supporting LFNs: file path 
construction is not standardized. But if Windows desktop, POSIX and 
POSIX-like OSes agree on something, then that effectively has become The 
Rule  that everybody followed for the last 40 years.

Besides, even then you'd still be stuck with contrib libraries, Lua 
scripts and external playlists. You can't even try to fix the latter.

Rémi Denis-Courmont

More information about the vlc-devel mailing list