[vlc-devel] [RFC] Memory keystore

[Rémi Denis-Courmont]

On Friday 05 February 2016 09:55:25 Thomas Guillem wrote:
> Hi,
> 
> In the following patch https://patches.videolan.org/patch/11925/, Rémi
> said:
> "Better yet, store everything in memory so we have a safe somewhat
> usable
> default implementation."
> 
> I like this idea but I have some questions:
> 
> 1/ Do we want to save passwords in memory during the live time of the
> process ?
> Or maybe during the live time of LibVLC ? (if so, LibVLC
> instance should have a reference to the memory keystore module)

I´d do whichever is easier - my guess is the earlier.

> 2/ If yes, should it be an option ? An option for each credentials (ask
> when showing login dialog) ? or a global option (activated or not by
> default) ? Since there is already an option to save the password
> permanently, adding a second option in the dialog to save it for the
> session may be disturbing for the user.

> Currently, the plaintext keystore module was developed for debugging
> purposes. I could rename it and re-arrange it to act as a memory module,
> with an optional option to save on disk and use this module when there
> is no other ones.

I would remove the file I/O support altogether. For testing purpose, in-memory 
should be enough (and better).

-- 
Rémi Denis-Courmont
http://www.remlab.net/