[vlc-devel] [PATCH] tools: fix cmake 3.2.3 building

Sean McGovern gseanmcg at gmail.com
Mon Feb 8 18:07:58 CET 2016


On Feb 8, 2016 11:57, "Steve Lhomme" <robux4 at gmail.com> wrote:
>
> On Mon, Feb 8, 2016 at 5:48 PM, Sean McGovern <gseanmcg at gmail.com> wrote:
> > Hi Steve,
> >
> > On Feb 8, 2016 10:48, "Steve Lhomme" <robux4 at videolabs.io> wrote:
> >>
> >> From: Steve Lhomme <robux4 at gmail.com>
> >>
> >> otherwise mode_t may not be defined
> >> ---
> >>  extras/tools/cmake-3.2.3.patch | 10 ++++++++++
> >>  extras/tools/tools.mak         |  3 ++-
> >>  2 files changed, 12 insertions(+), 1 deletion(-)
> >>  create mode 100644 extras/tools/cmake-3.2.3.patch
> >>
> >> diff --git a/extras/tools/cmake-3.2.3.patch
> >> b/extras/tools/cmake-3.2.3.patch
> >> new file mode 100644
> >> index 0000000..b697cc2
> >> --- /dev/null
> >> +++ b/extras/tools/cmake-3.2.3.patch
> >> @@ -0,0 +1,10 @@
> >> +--- cmake/Source/cmGeneratorExpressionEvaluationFile.h.orig
2016-02-04
> >> 11:47:52.735890500 +0100
> >> ++++ cmake/Source/cmGeneratorExpressionEvaluationFile.h 2016-02-04
> >> 11:46:06.493912300 +0100
> >> +@@ -14,6 +14,7 @@
> >> +
> >> + #include "cmStandardIncludes.h"
> >> + #include <cmsys/auto_ptr.hxx>
> >
> > It is usually a good idea to surround this with #if HAVE_SYS_TYPES_H,
> > however I'm not sure if cmake's configury tests for that.
>
> I'll give it a try. But since cmake builds cmake using cmake, I'm not
> sure it's even considered. Also the file is included many times
> elsewhere without this guard.
>

OK.

Don't worry about it then, this is probably an autotools-ism.

-- Sean McG.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160208/2ad1205c/attachment.html>


More information about the vlc-devel mailing list