[vlc-devel] [PATCH 2/2] vpx: add vp8 and vp9 encoder

[Jean-Baptiste Kempf]

On 08 Feb, Tristan Matthews wrote :
> > Are you sure this is the correct way and this is portable?
> 
> This is how I interpret the standard. From 6.7.8 Initialization:
> "If there are fewer initializers in a brace-enclosed list than there
> are elements or members of an aggregate, or fewer characters in a
> string literal used to initialize an array of known size than there
> are elements in the array, the remainder of the aggregate shall be
> initialized implicitly the same as objects that have static storage
> duration."

Sure. But since we're not using that anywhere else in VLC, I'd figure
this is not implemented everywhere.

> >> +    enccfg.g_threads = __MIN(vlc_GetCPUCount(), 16);
> >
> > 16 is a bit much, no?
> 
> It's what the decoder uses as an upper limit as well, but I could
> bring it down to 4.

No need, I'm just asking if it was truly tested with 16 threads.

With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device