[vlc-devel] [PATCH] access: enable ISDB-T layers

[HIRANO Takahito]

DTV_ISDBT_LAYER_ENABLED is added to the Linux kernel by the same commit as
DTV_ISDBT_LAYERA_FEC[1], which we are already using [2]. So this code
should compile if the original code compiles.

[1]
https://github.com/torvalds/linux/commit/b6e760f3097501e60e76fbcb7a313d42da930c1f
[2]
https://github.com/videolan/vlc/blob/master/modules/access/dtv/linux.c#L1115

2016-02-17 4:50 GMT+09:00 Rémi Denis-Courmont <remi at remlab.net>:

> On Wednesday 17 February 2016 00:33:39 HIRANO Takahito wrote:
> > Layer configurations were set, but layers have not been enabled. Some DVB
> > drivers are require them to be enabled to watch TV.
> >
> > Signed-off-by: HIRANO Takahito <hiranotaka at zng.info>
> > ---
> >  modules/access/dtv/linux.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/modules/access/dtv/linux.c b/modules/access/dtv/linux.c
> > index d0fa9f7..1d481f0 100644
> > --- a/modules/access/dtv/linux.c
> > +++ b/modules/access/dtv/linux.c
> > @@ -1131,9 +1131,10 @@ int dvb_set_isdbt (dvb_device_t *d, uint32_t freq,
> > uint32_t bandwidth,
> >
> >      if (dvb_find_frontend (d, ISDB_T))
> >          return -1;
> > -    if (dvb_set_props (d, 5, DTV_CLEAR, 0, DTV_DELIVERY_SYSTEM,
> SYS_ISDBT,
> > +    if (dvb_set_props (d, 6, DTV_CLEAR, 0, DTV_DELIVERY_SYSTEM,
> SYS_ISDBT,
> >                         DTV_FREQUENCY, freq, DTV_BANDWIDTH_HZ, bandwidth,
> > -                       DTV_GUARD_INTERVAL, guard))
> > +                       DTV_GUARD_INTERVAL, guard,
> > +                       DTV_ISDBT_LAYER_ENABLED, 0x7 /* all layer enabled
> > */))
> > return -1;
>
> Doesn´t this break compilation with some old versions of dvb/frontend.h ?
>
> >      for (unsigned i = 0; i < 3; i++)
> >          if (dvb_set_isdbt_layer (d, i, layers + i))
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160217/89505755/attachment.html>