[vlc-devel] [PATCH] include/vlc_plugin.h: fixed problematic linkage on callback argument

[Filip Roséen]

`EXTERN_SYMBOL` is a conditional macro defined as below in `vlc_plugin.h`:

    #if defined( __cplusplus )
    #   define EXTERN_SYMBOL           extern "C"
    #else
    #   define EXTERN_SYMBOL
    #endif

In other words, it will either expand to `extern "C"` when compiled as
C++, or nothing (when compiled as C).


------------------------------------------------------------------------------

On 16/02/22 21:07, Rémi Denis-Courmont wrote:

> Le 2016-02-22 18:28, Filip Roséen a écrit :
> >diff --git a/include/vlc_plugin.h b/include/vlc_plugin.h
> >index 46abe4e..950f6ad 100644
> >--- a/include/vlc_plugin.h
> >+++ b/include/vlc_plugin.h
> >@@ -234,7 +234,7 @@ enum vlc_module_properties
> > #   define EXTERN_SYMBOL
> > #endif
> >
> >-typedef int (*vlc_set_cb) (void *, void *, int, ...);
> >+EXTERN_SYMBOL typedef int (*vlc_set_cb) (void *, void *, int, ...);
> 
> Does Doxygen understand (i.e. ignore) the EXTERN_SYMBOL stanza?
> 
> Otherwise I don't know if this is valid, not familiar enough with C++.
> 
> >
> > #define vlc_plugin_set(...) vlc_set (opaque,   NULL, __VA_ARGS__)
> > #define vlc_module_set(...) vlc_set (opaque, module, __VA_ARGS__)
> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160222/01cc0e8f/attachment.html>