[vlc-devel] [PATCH 5/5] input: change "sub-file" option to "sub-url"

Rémi Denis-Courmont remi at remlab.net
Tue Feb 23 02:50:55 CET 2016


Le 2016-02-15 16:00, Thomas Guillem a écrit :
> On Sat, Feb 13, 2016, at 19:32, Rémi Denis-Courmont wrote:
>> This specific change was already rejected before and I don´t see any 
>> new
>> elements to discuss and potentially change the decision.
>
> So, my plan (that will be longer to develop):
>
>  - When parsing a directory via vlc: add input slaves (.ac3,.srt and 
> co)
>  to each new input items (using/adapting/improving the code in
>  subtitles_Detect)

I am not sure what you mean. I think the only practically deployable 
way to scan for subtitles is when opening a directory. It can either be 
done by the directory demuxer (ugly) or by a for-directories stream 
filter (less ugly).

It won't work if the input item was not created by the directory 
demuxer. But I fail to conceive an acceptable solution. Blocking 
scanning during input initialization is a non-starter for performance 
reasons. Non-blocking scanning is a non-starter because we would need 
the subtitles immediately (unlike covert art), and because it could 
overload the network in some cases.

>  - Add input_item_get_slaves()/input_item_add_slave()
>  - Add libvlc_media_get_slaves()/libvlc_media_set_slaves(): This will 
> be
>  used to store/restore the media slaves (.ac3, .srt and co) from a 
> media
>  library.

-- 
Rémi Denis-Courmont
http://www.remlab.net/


More information about the vlc-devel mailing list