[vlc-devel] [vlc-commits] access: vdr: fix null dereference (cid #1346943)

[Rémi Denis-Courmont]

Le 2015-12-31 19:44, git at videolan.org a écrit :
> vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Thu
> Dec 31 18:40:56 2015 +0100| 
> [3a22750ee684c732e8739123c167d4d5b84438fd]
> | committer: Francois Cartegnie
>
> access: vdr: fix null dereference (cid #1346943)
>
>> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3a22750ee684c732e8739123c167d4d5b84438fd
> ---
>
>  modules/access/vdr.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules/access/vdr.c b/modules/access/vdr.c
> index d2d840e..41bb42b 100644
> --- a/modules/access/vdr.c
> +++ b/modules/access/vdr.c
> @@ -874,7 +874,7 @@ static void ImportMarks( access_t *p_access )
>      }
>
>      /* add a chapter at the beginning if missing */
> -    if( p_marks->i_seekpoint > 0 && offsetv[0] > 0 )
> +    if( p_marks->i_seekpoint > 0 && offsetv && offsetv[0] > 0 )

WTH is this? offsetv cannot be NULL if i_seekpoint > 0. Duh.

Can you stop making nonsense "fixes" already?

-- 
Rémi Denis-Courmont
http://www.remlab.net/