[vlc-devel] [PATCH] macosx: First commit VLCStatusBarIcon code for macosx gui.

Goran Dokic vlc at 8hz.com
Sun Jan 3 11:36:33 CET 2016


On Sun, Jan 03, 2016 at 10:56:23AM +0100, David Fuhrmann wrote:
> Hi,
> 
> Here are some mode detailed comments.
> 
> In general: Please set your Xcode to automatically trim all trailing whitespaces, they are quite some in your patch. Also take care of tabs vs. 4 spaces - most of the files use 4 spaces instead of a tab.
> 

Hi David,

I didn't use xcode, except for massaging the xib :)

I'm working with trusty vi/vim on the console (old school). But I
cleaned the extra spaces, etc.

Thanks a lot for the detailed comments. I'll see if I can work through those
for a second patch.

Regards,

	goran

<SNIP>


More information about the vlc-devel mailing list