[vlc-devel] [RFC PATCH 4/8] configure: move and rework kde4-config detection

[Thomas Guillem]

On Thu, Dec 31, 2015, at 16:18, Rémi Denis-Courmont wrote:
> Le 2015-12-30 20:37, Thomas Guillem a écrit :
> > ---
> >  configure.ac | 9 +++++----
> >  1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 8cde97d..9582139 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -3777,6 +3777,11 @@ AS_IF([test "${enable_qt}" != "no"], [
> >  AM_CONDITIONAL(ENABLE_QT4, [test "$enable_qt" != "no"])
> >
> >  dnl
> > +dnl detect kde4-config patch (used for kde solids and kwallet).
> > +dnl
> > +AC_CHECK_PROG(KDE4_CONFIG, kde4-config, kde4-config, no)
> > +
> > +dnl
> >  dnl Simple test for skins2 dependency
> >  dnl
> >  AS_IF([test "$enable_qt" = "no"], [
> > @@ -4128,10 +4133,6 @@ AC_SUBST(DEFS_BIGENDIAN)
> >  dnl
> >  dnl Where to install KDE solid .desktop
> >  dnl
> > -AC_ARG_VAR([KDE4_CONFIG], [kde4-config utility])
> 
> Why?

Because KDE4_CONFIG is needed by KWallet config that is before in the
file.

> 
> > -AS_IF([test "x$KDE4_CONFIG" = "x"], [
> > -  KDE4_CONFIG="kde4-config"
> > -])
> >
> >  AC_ARG_WITH(kde-solid,
> >    AS_HELP_STRING([--with-kde-solid=PATH],
> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel