[vlc-devel] [PATCH] add in ability to read from any part of a file descriptor.

[Kevin Whitaker]

>
> What about fd://20#65477:445677 ?

It seems anything after a hash gets trimmed and I am then unable to get the
data that is normally stored in psz_location. If the trim process stores it
elsewhere I can access, I could work it like that.

Why long, and not off_t ?
>
Just an artifact of being new to vlc codebase and C. The data coming from
android is a long, so I mentally kept it the same here. Let me know if this
is something that is worth changing.

Please do not change the coding style
>
Are you referring to the longs or something else?

Why not strdup?
>
I simply was not familiar with this other C string function. It does look
more appropriate. I'll change it to use strdup instead of strcpy and malloc.



On Tue, Jan 5, 2016 at 9:46 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> On 05 Jan, Kevin Whitaker wrote :
>> +    long fd_offset;
>
> Why long, and not off_t ?
>
>> +    long fd_size;
>
> Why long and not off_t ?
>
> With my kindest regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



-- 
Kevin Whitaker
Application Engineer | LISNR
kevin at lisnr.com

  website | twitter | facebook


 LISNR in the News:
 CNBC - 2015 CNBC Disruptor 50 companies
 Adweek - McDonald's 'Shark Tank' Winner at SXSW
 TechCrunch - R/GA Accelerator Demo Day

This email and any files transmitted with it are confidential and intended
solely for the use of the individual or entity to whom they are addressed.
If you are not the named addressee, you should not disseminate, distribute
or copy this email. Please notify the sender immediately by email if you
have received this email by mistake and delete this email from your system.
If you are not the intended recipient, you are notified that disclosing,
copying, distributing or taking any action in reliance on the contents of
this information is strictly prohibited.  Please note that any views or
opinions presented in this email are solely those of the author and do not
necessarily represent those of the LISNR, INC.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160105/095e2096/attachment.html>