[vlc-devel] [PATCH 06/11] keystore: add kwallet module

[Rémi Denis-Courmont]

On Wednesday 06 January 2016 16:56:26 Thomas Guillem wrote:
> +static int
> +Open(vlc_object_t *p_this)
> +{
> +    /* KWallet and DBus methods need to be run from the QApplication main
> loop. +     * There can be only one QApplication and it's currently used by
> the qt +     * interface.
> +     * TODO: Spawn the Qt thread singleton from here or from the qt
> interface +     * module */
> +    QCoreApplication *p_qApp = QCoreApplication::instance();

I very much doubt that this call is re-entrant/thread-safe.

Also AFAIR, the agreement with KDE people was to use D-Bus, not libKWallet.

-- 
Rémi Denis-Courmont
http://www.remlab.net/