[vlc-devel] [PATCH 1/2] cache_block: follow block->i_size for memory usage

Ilkka Ollakka ileoo at videolan.org
Sun Jan 31 14:57:27 CET 2016

On Sat, Jan 30, 2016 at 05:52:19PM +0200, Rémi Denis-Courmont wrote:
> Le 2016-01-30 13:54, Ilkka Ollakka a écrit :
> >Should be more accurate on actual memory usage, block->i_buffer just
> >mentions how much usefull payload there is.

> Same problem as François' patch: it divides the effective buffer size by a
> typically over 40 factor, pretty much ruining it.


After UDP overallocation is fixed (patch send), I think Francois's patch
should be taken back to consideration. Atleast code comments talks about memory
usage and it then should focus more on actual memory usage instead of
just playbook bookkeeping.

DTV is another access that has this issue of overallocating, but I can
try to check it next. But I'm not sure if buffer of tens of megabytes is
necessary in that at all.

Ilkka Ollakka
				Dorothy Gale

	Auntie Em:
		Hate you.
		Hate Kansas.
		Taking the dog.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160131/601aca8a/attachment.sig>

More information about the vlc-devel mailing list