[vlc-devel] [PATCH] smem: do not crash if the callbacks are not defined

Adrien Maglo magsoft at videolan.org
Thu Jul 7 00:03:02 CEST 2016


Le 06/07/2016 21:46, Rémi Denis-Courmont a écrit :
> On Wednesday 06 July 2016 16:05:38 Adrien Maglo wrote:
>> ---
>>   modules/stream_out/smem.c | 26 ++++++++++++++++++++------
>>   1 file changed, 20 insertions(+), 6 deletions(-)
>
> Looks OK though I don´t really see the point beating the dead smem horse
> further. IMHO, I´d check for NULL at init and replace with a default callback.

That makes sense. I will propose a second version of the patch.

Thanks for the review.


-- 
MagSoft



More information about the vlc-devel mailing list